Optimize getBundlePEM#1490
Conversation
This was the top allocation on the heap. See if we can optimize it a bit Jira: OSPRH-17235
|
|
||
| for _, cert := range cab.certs { | ||
| bundleData += "# " + cert.cert.Issuer.CommonName + "\n" + | ||
| string(pem.EncodeToMemory(&pem.Block{Type: "CERTIFICATE", Bytes: cert.cert.Raw})) |
There was a problem hiding this comment.
avoiding the use of EncodeToMemory was the goal here
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/63393a442d1941fd8732e3b28fe4b31c ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 32m 57s |
|
recheck |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
openshift-merge-bot
Bot
merged commit 32d7fd2
into
openstack-k8s-operators:main
|
/cherry-pick 18.0-fr3 |
|
@stuggi: new pull request created: #1502 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
This was the top allocation on the heap. See if we can optimize it a bit
Jira: OSPRH-17235